Loosen NumPy version requirement to allow version 2#763
Merged
Conversation
sergeisakov
approved these changes
Jun 13, 2025
dstrain115
approved these changes
Jun 13, 2025
| numpy~=1.16 | ||
| pybind11 | ||
| numpy>=1.26.0 | ||
| pybind11[global] |
There was a problem hiding this comment.
What does the global signify? Is that because we added platform dependent stuff in the other PRs?
Collaborator
Author
There was a problem hiding this comment.
@dstrain115 The global option makes it include pybind11 CMake files in a location accessible from a more standard system location. In addition to going into $VIRTUAL_ENV/lib/python3.9/site-packages/pybind11/share/cmake, it goes into $VIRTUAL_ENV/share/cmake. This makes it possible for CMake to find them on some platforms (I think Windows was the problematic one).
There was a problem hiding this comment.
Is it worth a one-line comment to explain this?
Collaborator
Author
There was a problem hiding this comment.
That makes sense. I'll do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the min version of NumPy to 1.26 and allow NumPy 2.